Accepter plusieurs types de fichiers

Sha-ka

Nouveau WRInaute
Bonjour.

J'ai un formulaire pour uploader des images (avec création de miniatures et contrôles), seulement, j'aimerais aussi avoir la possibilité d'uploader des swf sans passer par le ftp, donc en utilisant le même formulaire. 3 soucis : le code ne vient pas de moi mais est issu d'un code tout fait, il y'a plusieurs contrôles et chaque erreur renvoie toujours le même message, donc difficile de déterminer d’où vient précisément le problème. A noter que je ne désire pas créer d'image miniature pour les fichiers .swf.

La page post_add :

Code:
if(isset($_POST['submit']))
    {
        $image = new image();
        $uploaded_image = false;
        $parent = '';
        $error = '';
        if(empty($_FILES['upload']) && isset($_POST['source']) && $_POST['source'] != "" && substr($_POST['source'],0,4) == "http" || $_FILES['upload']['error'] != 0 && isset($_POST['source']) && $_POST['source'] != "" && substr($_POST['source'],0,4) == "http")
        {
            $iinfo = $image->getremoteimage($_POST['source']);
            if($iinfo === false)
                $error = $image->geterror()."<br />Could not add the image.";
            else
                $uploaded_image = true;
        }
        else if(!empty($_FILES['upload']) && $_FILES['upload']['error'] == 0)
        {
            $iinfo = $image->process_upload($_FILES['upload']);
            if($iinfo === false)
                $error = $image->geterror()."<br /> An error occured. The image could not be added because it already exists or it is corrupted.";
            else
                $uploaded_image = true;
        }
        else
        {
            print "No image given for upload.";
        }
        if($uploaded_image == true)
        {
            $iinfo = explode(":",$iinfo);
            $tclass = new tag();
            $misc = new misc();
            $ext = strtolower(substr($iinfo[1],-4,10000));
            $source = mysql_real_escape_string($_POST['source']);
            $title = mysql_real_escape_string($_POST['title']);
            $tags = strtolower(mysql_real_escape_string(str_replace('%','',str_replace("'","&#039;",str_replace('"','&quot;',$_POST['tags'])))));
            $tags = strip_tags($tags);
            $ttags = explode(" ",$tags);
            $tag_count = count($ttags);     
            if($tag_count == 0)
                $ttags[] = "tagme";
            if($tag_count < 5 && strpos($ttags,"tagme") === false)
                $ttags[] = "tagme";
            foreach($ttags as $current)
            {
                if(strpos($current,'parent:') !== false)
                {
                    $parent = str_replace("parent:","",$current);
                    if(!is_numeric($parent))
                    {
                        //messed up parent id, removing...
                        $parent = '';
                    }
                    $current = '';                                      
                }
                if($current != "" && $current != " ")
                {
                    $ttags = $tclass->filter_tags($tags,$current, $ttags);
                    $alias = $tclass->alias($current);
                    if($alias !== false)
                    {
                        $key_array = array_keys($ttags, $current);
                        foreach($key_array as $key)
                        {
                            $ttags[$key] = $alias;
                        }
                
                    }
                }
            }
            $tags = implode(" ",$ttags);
            foreach($ttags as $current)
            {
                if($current != "" && $current != " ")
                {
                    $ttags = $tclass->filter_tags($tags,$current, $ttags);
                    $tclass->addindextag($current);
                    $cache = new cache();
                    if(is_dir("$main_cache_dir".""."\search_cache/".$misc->windows_filename_fix($current)."/"))
                        $cache->destroy_page_cache("search_cache/".$misc->windows_filename_fix($current)."/");
                }
            }
            asort($ttags);
            $tags = implode(" ",$ttags);
            if(substr($tags,0,1) != " ")
                $tags = " $tags";
            if(substr($tags,-1,1) != " ")
                $tags = "$tags ";
            $rating = mysql_real_escape_string($_POST['rating']);
            if($rating == "e")
                $rating = "Explicit";
            else if($rating == "q")
                $rating = "Questionable";
            else
                $rating = "Safe";
            if(isset($_SESSION['id']) && $_SESSION['id'] != "" && isset($_SESSION['login_session']) && $_SESSION['login_session'] != "")
            {
                $query = "SELECT user FROM $user_table WHERE id='".mysql_real_escape_string($_SESSION['id'])."' AND login_session='".mysql_real_escape_string($_SESSION['login_session'])."'";
                $result = mysql_query($query);
                $row = mysql_fetch_assoc($result);
                $user = $row['user'];
            }
            else
            {
                $user = "Anonymous";
            }
            if(isset($_SERVER['HTTP_X_FORWARD_FOR'])) 
                $ip = mysql_real_escape_string($_SERVER['HTTP_X_FORWARD_FOR']);
            else
                $ip = mysql_real_escape_string($_SERVER['REMOTE_ADDR']);
            $isinfo = getimagesize("./images/".$iinfo[0]."/".$iinfo[1]);
            $query = "INSERT INTO $post_table(creation_date, hash, image, title, owner, height, width, ext, rating, local_copy, tags, directory, source, active_date, ip) VALUES(NOW(), '".md5_file("./images/".$iinfo[0]."/".$iinfo[1])."', '".$iinfo[1]."', '$title', '$user', '".$isinfo[1]."', '".$isinfo[0]."', '$ext', '$rating', TRUE, '$tags', '".$iinfo[0]."', '$source', '".date("Ymd")."', '$ip')";
                if(!is_dir("$main_cache_dir".""."\thumbnails/".$iinfo[0]."/"))
                    $image->makethumbnailfolder($iinfo[0]);
                $image->thumbnail($iinfo[0]."/".$iinfo[1]);
            if(!mysql_query($query))
            {
                print "failed to upload image.";
                unlink("./images/".$iinfo[0]."/".$iinfo[1]);
                $image->folder_index_decrement($iinfo[0]);
                $ttags = explode(" ",$tags);
                foreach($ttags as $current)
                {
                    $tclass->deleteindextag($current);
                }
            }
            else
            {
                $query = "SELECT id FROM $post_table WHERE hash='".md5_file('./images/'.$iinfo[0]."/".$iinfo[1])."' AND image='".$iinfo[1]."' AND directory='".$iinfo[0]."'  LIMIT 1";
                $result = mysql_query($query);
                $row = mysql_fetch_assoc($result);
                $cache = new cache();               
                if($parent != '' && is_numeric($parent))
                {
                    $parent_check = "SELECT COUNT(*) FROM $post_table WHERE id='$parent'";
                    $pres = mysql_query($parent_check);
                    $prow = mysql_fetch_assoc($pres);
                    if($prow['COUNT(*)'] > 0)
                    {
                        $temp = "INSERT INTO $parent_child_table(parent,child) VALUES('$parent','".$row['id']."')";
                        mysql_query($temp);
                        $temp = "UPDATE $post_table SET parent='$parent' WHERE id='".$row['id']."'";
                        mysql_query($temp);
                        $cache->destroy("cache/".$parent."/post.cache");    
                    }
                }               
                if(is_dir("$main_cache_dir".""."cache/".$row['id']))
                    $cache->destroy_page_cache("cache/".$row['id']);
                $query = "SELECT id FROM $post_table WHERE id < ".$row['id']." ORDER BY id DESC LIMIT 1";
                $result = mysql_query($query);
                $row = mysql_fetch_assoc($result);
                $cache->destroy_page_cache("cache/".$row['id']);

                $query = "UPDATE $post_count_table SET last_update='20060101' WHERE access_key='posts'";
                mysql_query($query);

                print "Image added.";




                

            }
        }
    }


Page de contrôle :

Code:
function process_upload($upload)
        {
            global $min_upload_width, $min_upload_height, $max_upload_width, $max_upload_height;
            if($upload == "")
                return false;
            $ext = explode('.',$upload['name']);
            $count = count($ext);
            $ext = $ext[$count-1];
            $ext = strtolower($ext);
            if($ext != "jpg" && $ext != "jpeg" && $ext != "gif" && $ext != "png" && $ext != "bmp" && $ext != "swf")
                return false;
            $ext = ".".$ext;
            $fname = hash('sha1',hash('md5',$upload['name']));
            move_uploaded_file($upload['tmp_name'],"./tmp/".$fname.$ext);
            $f = fopen("./tmp/".$fname.$ext,"rb");
            if($f == "")
                return false;
            $data = '';
            while(!feof($f))
            {
                $data .= fread($f,4096);
            }
            fclose($f);
            if(preg_match("#<script|<html|<head|<title|<body|<pre|<table|<a\s+href|<img|<plaintext#si", $data) == 1)
            {   
                unlink("./tmp/".$fname.$ext);
                return false;
            }
            if($ext=="swf"){
			  
			}
			else{
			$iinfo = getimagesize("./tmp/".$fname.$ext);
            if(substr($iinfo['mime'],0,5) != "image" || $iinfo[0] < $min_upload_width && $min_upload_width != 0 || $iinfo[0] > $max_upload_width && $max_upload_width != 0 || $iinfo[1] < $min_upload_height && $min_upload_height != 0 || $iinfo[1] > $max_upload_height && $max_upload_height != 0 || !$this->checksum("./tmp/".$fname.$ext))
            {
                unlink("./tmp/".$fname.$ext);
                return false;
            }
            $ffname = $fname;
            $cdir = $this->getcurrentfolder();
            $i = 0;
            if(!is_dir("./images/".$cdir."/"))
                $this->makefolder($cdir);
            while(file_exists("./images/".$cdir."/".$fname.$ext))
            {
                $i++;
                $fname = hash('sha1',hash('md5',$fname.$i));
            }
            $f = fopen("./images/".$cdir."/".$fname.$ext,"w");
            if($f == "")
                return false;
            fwrite($f,$data);
            fclose($f);
            $this->folder_index_increment($cdir);
            unlink("./tmp/".$ffname.$ext);
            return $cdir.":".$fname.$ext;
            }
        }

D'avance merci.
 

sonn

WRInaute discret
Euh.. j'ai regarder vite fait. Mais faire attention a la faille du byte null.
genre si tu rajoute simplement une extension a un fichier, genre .txt et que tu upload un fichier appeler blackhat.php\0 ton fichier seras nommer blackhat.php et don le script qu'il contient pourras etre exécuter par un méchant.
le script semble pas etre vulnérable mais je t'apprend des trucs ;) je regarderais demain, c'est promis :p
 

Sha-ka

Nouveau WRInaute
Le contrôle du fichier est déjà effectué quand c'est une image.. Comment faire quand on veut un swf ?
 

Discussions similaires

Haut